Fix invalid semantic HTML: <button> nested inside <a> in not-found.tsx#41
Merged
naheel0 merged 2 commits intonot-found-pagefrom Feb 21, 2026
Merged
Fix invalid semantic HTML: <button> nested inside <a> in not-found.tsx#41naheel0 merged 2 commits intonot-found-pagefrom
<button> nested inside <a> in not-found.tsx#41naheel0 merged 2 commits intonot-found-pagefrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…found.tsx Co-authored-by: naheel0 <191262736+naheel0@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Create not-found.tsx UI component
Fix invalid semantic HTML: Feb 21, 2026
<button> nested inside <a> in not-found.tsx
naheel0
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Back to Safety" CTA was wrapping a
<Button>(renders<button>) inside a<Link>(renders<a>), producing invalid HTML — interactive elements cannot be nested.Change
Used
Button's existingasChildprop so Radix UI'sSlotforwards button styles directly onto the<Link>child, collapsing both into a single<a>element.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.